The Code Review Pyramid
Best Practices
In doing a code review, you should make sure that:
- The code is readable
- It has appropriate unit tests
- The developer used clear names for everything
- The code is well-designed and isn’t more complex than it needs to be
- Test cases make sense and have comprehensive coverage
- It’s something the team can maintain in the long run
- There are no architectural issues that will block the team
- The code fits the team’s idea of quality
- You’re thinking about what you can learn from the PR
- You’re sharing any knowledge the developer might use in their PR
- You’re thinking about how you can empower the dev through your positive feedback
- The PR has a clear changelist description
References
📂 Misc | Последнее изменение: 04.12.2024 16:57